RFC: osmo_ip_port API proposal

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Harald Welte laforge at gnumonks.org
Fri Mar 8 11:25:58 UTC 2019


Hi all,

Neels has recently proposed an osmo_ip_port API, see
https://gerrit.osmocom.org/#/c/libosmocore/+/13123

I'm somewhat reluctant to get this merged into libosmocore, as from my point
of view, it's reinventing what sockaddr_storage is doing in libc, but storign
the address in host byte order and string format.  So I would argue we should
rather create helper/utility functions around sockaddr_storage and do any
string/binary and endianness conversions hidden by/within that API.

Irrespective of the above, I would want to hear what other developers think. Do
you think that it's worthwhile to

1) have some utility functions / infrastructure (irrespective of the data type)
1a) in libosmocore, or
1b) keep it to osmo-mgw

2) prefer to
2a) have strings for IP adresses and host-byte-order port numbers like the proposed patchset, or 
2b) go with native sockaddr_storage?

If others think it should be merged, I won't try to veto it.  I just want to
hear some more voices rather than just my own point-of-view.

Regards,
	Harald
-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)



More information about the OpenBSC mailing list