voting in gerrit: merge at +3? (+2+1 / +1+1+1)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Stefan Sperling stsp at stsp.name
Tue Dec 11 07:58:53 UTC 2018


On Tue, Dec 11, 2018 at 12:44:34AM +0100, Neels Hofmeyr wrote:
> I do think it sucks that it doesn't show the status properly; you always need
> to click around and manually sum up CR votes to see where you're at.  It's
> quite a half-arsed implementation, little more than a quick example.

Well... We are doing code review via a *web interface*
So what else would you expect?

> Oh, BTW, do some people still get the right to +2, so that actually only two
> reviews are needed if one of them voted +2? Or does everyone only +1 now?
> (easy to configure and enforce)

Current +2 / +1 vote token assignments shouldn't change.
This was never explicitly discussed, but it was implied.



More information about the OpenBSC mailing list