This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Vadim Yanitskiy axilirator at gmail.comHi, > written manually? Yes. Just look at content of this header file. > We tend to put all headers used from several locations in > openbsc/openbsc/include/openbsc/ (as noinst_HEADERS in the Makefile.am). > To #include, you would use something like #include <openbsc/conv.h>. Yeah, I tried to put one into include/osmocom/tests/, but Harald and Sylvain voted against this approach. So I decided to go this way. With best regards, Vadim Yanitskiy. 2017-05-02 17:52 GMT+07:00 Neels Hofmeyr <nhofmeyr at sysmocom.de>: > On Mon, May 01, 2017 at 03:41:03AM +0700, Vadim Yanitskiy wrote: > > > We generate "conv.h" and put it into the source directory? > > > > Actually, no. We aren't generate the "conv.h". > > It's written manually and contains the conv_test_vector > > structure definition and the do_check() function definition. > > written manually? You mean committed in gerrit, right? > > > One was introduced by: https://gerrit.osmocom.org/#/c/1627/ > > so now the same test logic is used in two different tests > > (both conv and conv_gsm0503) without code duplication. > > We tend to put all headers used from several locations in > openbsc/openbsc/include/openbsc/ (as noinst_HEADERS in the Makefile.am). > To #include, you would use something like #include <openbsc/conv.h>. > > > Don't you confuse it with the "gsm0503.h", which is exactly > > generated by the "utils/conv_gen.py"? > > Loosely related: some time back I modified some generation code to put > generated C files in the builddir, adding -I$(builddir) to be able to find > them from srcdir... I think it was this one I fixed. > > ~N > > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20170503/9e2da411/attachment.htm>