[MERGED] openbsc[master]: gsm0408: Adding log output for 3g specific RR messages

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Harald Welte laforge at gnumonks.org
Wed Nov 2 17:16:38 UTC 2016


Hi Neels,

On Wed, Nov 02, 2016 at 02:14:13PM +0100, Neels Hofmeyr wrote:
> >  		case GSM48_MT_RR_STATUS:
> > -			LOGP(DRR, LOGL_NOTICE, "RR STATUS (cause: %s)\n",
> > -				rr_cause_name(gh->data[0]));
> > +			LOGP(DRR, LOGL_NOTICE, "%s (cause: %s)\n",
> > +			     gsm48_rr_msg_name(GSM48_MT_RR_GPRS_SUSP_REQ),
> 
> Although this is in case GSM48_MT_RR_STATUS, it logs GSM48_MT_RR_GPRS_SUSP_REQ.
> I'd prefer it it logs gsm48_rr_msg_name(msg_type), also in the call above, and
> like the patch does below.

ACK.  Philipp, would be great if you could fix that up.

Thanks,
	Harald
-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)



More information about the OpenBSC mailing list