[PATCH 2/3] add bind address parameter to ctrl_interface_setup()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Neels Hofmeyr nhofmeyr at sysmocom.de
Wed Feb 24 13:38:26 UTC 2016


On Wed, Feb 24, 2016 at 10:06:48AM +0100, Harald Welte wrote:
> Hi Neels,
> 
> On Wed, Feb 24, 2016 at 03:39:37AM +0100, Neels Hofmeyr wrote:
> > -struct ctrl_handle *ctrl_interface_setup(void *data, uint16_t port,
> > -					 ctrl_cmd_lookup lookup);
> > +struct ctrl_handle *ctrl_interface_setup(void *data, const char *bind_addr,
> > +					 uint16_t port, ctrl_cmd_lookup lookup);
> 
> we generally don't beak interfaces of our libraries like this.  Pleaes

I was suspecting so. "Just checking if you're paying attention" ;)

> See telnet_init_dynif() vs. telnet_init() in libosmovty.

exactly what I had in mind. _dynif is a good suffix to reuse then, I assume.

Thanks!

~Neels

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20160224/7adfe48e/attachment.bin>


More information about the OpenBSC mailing list