This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Daniel Willmann dwillmann at sysmocom.deHey Neels, On Thu, 2016-02-18 at 23:45 +0100, Neels Hofmeyr wrote: > Moin Daniel :) > > (1) > About ebd4d820b3b0d7ba5db3b25a14f407d0c7276044 > "libiu: Use custom setupormodifieditemies function" > > It seems you forgot to commit the actual function definition of > ranap_decode_rab_setupormodifieditemies_fromlist() > I got the caller of it only and thus can't compile as-is. osmo-iuh commit 635fac0c3eef has both the function and the declaration. > (2) > About 38e2f1bca4e43414ed39a938d7c5d8bafe5e8533 > " > Revert "iu.c: avoid warning by declaring ranap_free_rab_setupormodifieditemies()" > > There should be no need to silence this warning, the ranap_free_* > functions are declared in libranap headers. In any case this will only > obscure any real issue. Maybe osmo-iuh was not rebuilt completely > (including generation of the c files from the python script). > > This reverts commit 05ae5b1245f95bf765b42e49af7b2596e013f0a0. > " > > I declared ranap_free_rab_setupormodifieditemies() like that because it again) to add the function declarations to the ies_defs.h file.is > indeed not declared in a header that is installed. Also a grep tells me > that no ranap_free_* is found in any osmo-iuh header file at all. > I also did a 'make regen' in osmo-iuh/src/ to no avail. > By 'libranap headers' I assume you mean libosmo-ranap, or is there a > libranap I'm not aware of yet? > If the ranap_free_* aren't in headers yet, I agree that they should be. I > wanted to silence the warning without being sucked down the rabbit hole of > autogenerated asn1 stuff. Any suggestions: more than welcome. Bummer, you're right. It seems the script doesn't generate the free() declarations. I'll fix that. > (3) > I think it's a healthy premise that we all commit mostly bollocks and all > needs refinement anyway... once again: push it! :) Yeah, well, this time I did ;-) -- - Daniel Willmann <dwillmann at sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte