gerrit comment example (from Qt)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Freyther holger at freyther.de
Fri Apr 22 12:23:02 UTC 2016


Hi,

I subscribed myself to more change notifications on another gerrit to see how the coments would look like. there is not a lot o context but at least some.



> Begin forwarded message:
> 
> Jesus Fernandez has posted comments on this change.
> 
> Change subject: Possible crash in QMakeSourceFileInfo
> ......................................................................
> 
> 
> Patch Set 7:
> 
> (6 comments)
> 
> Thank you
> 
> ....................................................
> File qmake/generators/makefiledeps.cpp
> Line 606
> It's really weird, but you're right.
> 
> Dropped... I mean Done.
> 
> 
> Line 648
> Done
> 
> 
> Line 655
> Done
> 
> 
> Line 667
> Done
> 
> 
> Line 592:                             for (x += 1 ; x + inc_len < buffer_len && buffer[x + inc_len] != '<';
> And an extra whitespace :)
> 
> Done!
> 
> 
> Line 639:                     for (x += 1; x + inc_len < buffer_len && buffer[x + inc_len] != '<';
> Done




More information about the OpenBSC mailing list