This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Harald Welte laforge at gnumonks.orgHi Alexander,
On Mon, Sep 07, 2015 at 01:08:47AM -0500, Alexander Chemeris wrote:
> > * a so-called 'fix for use after free' that is actually a patch that
> > introduces another copy for every primitive and is only required for
> > the loopback mode
>
> I'd appreciate recommendations on how to do this differently. IIRC the
> code frees messages after the function and the queue was pointing to a
> freed message. this led to undefined behavior.
>
> There is a companion patch to this to manually activate/deactivate a
> channel. I'd appreciate recommendations on how to properly implement
> it as well. Loopback and channel activation functions are very helpful
> for the L0/L1 development.
I don't really have a good response for this, other than to keep it out
of master (or maybe even a compile time option). 99.9% of all
installations will not have any benefit from the extra memcpy(), so I
don't want to make it the standard behavior.
> We're little busy this week, so assume we're ok by default. If we find
> time for testing and find something - we'll let you know. Worst case
> we'll fix TRX support after it's merged.
agreed.
> Could you share what kind of testing has been performed, so we can
> shape our expectations?
Not much, to be honest. We will test for osmo-bts-sysmo during this
week. However, no testing will be done by me regarding the osmo-trx
related code.
Regards,
Harald
--
- Harald Welte <laforge at gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)