[PATCH] convert literal APN name to protocol encoded version before use

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Harald Welte hwelte at sysmocom.de
Mon Nov 16 08:59:23 UTC 2015


Hi Jacob,

On Mon, Nov 16, 2015 at 09:46:58AM +0100, Jacob Erlbeck wrote:

> Nevertheless most of the basic GPRS stuff (e.g. gsm_04_08_gprs.c which
> is on a similar level) is still in openbsc, so I would like to have more
> of a concept (gsm, gb, or a new gprs lib? Name prefix?) before starting
> refactoring.

I would argue to put more things into libosmogsm.  We already have
plenty of libraries and I think there's not much point to have even more
fragmentation.  I mean, we're not talking about hundreds of megabyte of
boost-enabled C++ code, but some amount of helper functions here.

libosmogb should stay related specific to the Gb (NS/BSSGP) interface, I
think that's a pretty clean/clear split.

In terms of prefixing: libosmogsm uses gsm* where * is for the reduced
spec number, and some gprs_* symbols.  I think it's hard to come up with
a detailed rule, but I'd say as long as it fits within that scheme it is
fine.

Starting now to prefix eveything with osmo_ seems a bit ridiculous, with
all the existing other-prefixed symbols. but let's kepe the nubmer of
prefixes limited ;)

-- 
- Harald Welte <hwelte at sysmocom.de>             http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte



More information about the OpenBSC mailing list