[PATCH] convert literal APN name to protocol encoded version before use

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Jacob Erlbeck jerlbeck at sysmocom.de
Mon Nov 16 09:35:56 UTC 2015


Hi Harald,

On 16.11.2015 09:59, Harald Welte wrote:
> I would argue to put more things into libosmogsm.  We already have
> plenty of libraries and I think there's not much point to have even more
> fragmentation.  I mean, we're not talking about hundreds of megabyte of
> boost-enabled C++ code, but some amount of helper functions here.
> 
> libosmogb should stay related specific to the Gb (NS/BSSGP) interface, I
> think that's a pretty clean/clear split.

Agreed.

> In terms of prefixing: libosmogsm uses gsm* where * is for the reduced
> spec number, and some gprs_* symbols.  I think it's hard to come up with
> a detailed rule, but I'd say as long as it fits within that scheme it is
> fine.
> 
> Starting now to prefix eveything with osmo_ seems a bit ridiculous, with
> all the existing other-prefixed symbols. but let's kepe the nubmer of
> prefixes limited ;)

I just came across gsm/apn.c (which seems to be a sensible place to put
the conversion functions) where are currently definitions of
osmo_apn_qualify and osmo_apn_qualify_from_imsi. So for the sake of
consistency I can move the function there as osmo_apn_from_str/to_str.

Jacob

-- 
- Jacob Erlbeck <jerlbeck at sysmocom.de>       http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte



More information about the OpenBSC mailing list