[PATCH] opensgsn: Replace some TODOs with error paths and fix compiler warning

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Mike McTernan (wavemobile) mike.mcternan at wavemobile.com
Tue Apr 28 11:59:16 UTC 2015


Hi Holger,

> this error check is not complete. sendmsg returns the number of bytes sent.

Whoops!

> Do you have time to extend this check?

Sure.  I've fixed this in the attached v2 of the patch.  It was tested by running the following to make sure that code path was reached and passed (which was also verified with a temporary printf):

./sgsnemu --contexts=4 -l 127.0.0.1 -r 127.0.0.2 -d --createif  --net 0.0.0.0

Kind Regards,

Mike

-------------- next part --------------
A non-text attachment was scrubbed...
Name: Check-and-fix-tun-setup-error-paths-v2.patch
Type: application/octet-stream
Size: 1763 bytes
Desc: Check-and-fix-tun-setup-error-paths-v2.patch
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20150428/c5a02ea0/attachment.obj>


More information about the OpenBSC mailing list