[PATCH] opensgsn: Replace some TODOs with error paths and fix compiler warning

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Freyther holger at freyther.de
Tue Apr 28 10:48:57 UTC 2015


> On 28 Apr 2015, at 12:06, Mike McTernan (wavemobile) <mike.mcternan at wavemobile.com> wrote:

hi!


> +    status = sendmsg(fd, &msg, 0);
> +    if (status == -1) {

this error check is not complete. sendmsg returns the number of bytes
sent. This means we should check if everything we wanted to send has
been sent (we were bitten by truncated LLE frames in GPRS-NS early
on).

Do you have time to extend this check?

holger




More information about the OpenBSC mailing list