[PATCH] sms_test: Use C99 initializers.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Alexander Chemeris alexander.chemeris at gmail.com
Sun Mar 16 11:14:21 UTC 2014


Hi Holger,

On Sun, Mar 16, 2014 at 1:55 PM, Holger Hans Peter Freyther
<holger at freyther.de> wrote:
> E.g. in one
> of the testcases I noticed that you don't use C99 initializers but the
> old/error prone way of initializing. :)

Yes, I think in this particular case the old way is more compact and
thus more readable.

I added C99 initializers to the test (see the patch attached or
achemeris/sms-fixes branch) and to me it looks less readable and thus
more error prone. If you see any benefits of this patch - feel free to
merge it, though.

-- 
Regards,
Alexander Chemeris.
CEO, Fairwaves, Inc. / ООО УмРадио
https://fairwaves.co
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-sms_test-Use-C99-initializers.patch
Type: text/x-patch
Size: 7513 bytes
Desc: not available
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20140316/e5572080/attachment.bin>


More information about the OpenBSC mailing list