[PATCH 1/3] smpp_smsc: Print errno and close socket if read returns -1

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Daniel Willmann dwillmann at sysmocom.de
Tue Jan 28 17:26:26 UTC 2014


On Sun, 2014-01-26 at 08:44, Holger Hans Peter Freyther wrote:
> Maybe it is time for gerrit or at least a set-up for patchwork. I had
> a look at your branch and stopped at the first commit message. :)

In an attempt to prevent issues with my other patches I reviewed them
again and found some more issues. I pushed an updated and rebased
version to daniel/smpp-fixes and will send the patchset here as well.

> "Before this patch we just loop over the fd with read returning -1.."
> ==> looped (past tense)?

Right, fixed.

> I don't think it is true. osmo_fd_register will enable O_NONBLOCK on
> the socket and I think we use that to register the fd.

You're right, the reason is wrong. Checking for these codes is still not
needed, though (since we get called only if there's something to read.

> the actual fixes look nice though. :)

At least something :-)


Regards,
Daniel

-- 
- Daniel Willmann <dwillmann at sysmocom.de>       http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Schivelbeiner Str. 5
* 10439 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte




More information about the OpenBSC mailing list