[PATCH 1/3] smpp_smsc: Print errno and close socket if read returns -1

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Daniel Willmann dwillmann at sysmocom.de
Tue Jan 21 13:32:57 UTC 2014


On Mon, 2014-01-20 at 20:28, Holger Hans Peter Freyther wrote:
> On Mon, Jan 20, 2014 at 07:47:23PM +0100, Daniel Willmann wrote:
> 
> > I found another issue as well which I rolled into my last patch.
> > msgb_alloc takes a uint16_t as size so the check was still wrong.
> 
> good catch! Shall we export something from MSGB to indicate the
> maximum msgb size?

I'm not opposed, but I don't see how it would help anything. I doubt
that whoever forgot to check the function signature will remember to
compare the length against a define.


Regards,
Daniel

-- 
- Daniel Willmann <dwillmann at sysmocom.de>       http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Schivelbeiner Str. 5
* 10439 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte




More information about the OpenBSC mailing list