[PATCH] bsc: Add control command to set timezone

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Peter Stuge peter at stuge.se
Tue Oct 1 21:00:32 UTC 2013


Jacob Erlbeck wrote:
> +	if ((tz_hours < -19) || (tz_hours > 19) ||
> +	       (tz_mins < 0) || (tz_mins >= 60) || (tz_mins % 15 != 0) ||
> +	       (tz_dst < 0) || (tz_dst > 2))
> +		goto err;

No need for all these parentheses, but oh well.

More importantly - are you sure that daylight savings is only ever 0,
1 or 2 hours? I seem to remember that this isn't true for some odd
place, but unfortunately I don't remember where, so this would need
a bit of research.. :\


//Peter




More information about the OpenBSC mailing list