This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Holger Hans Peter Freyther holger at freyther.deOn Tue, Oct 01, 2013 at 01:26:42PM +0200, Jacob Erlbeck wrote:
Dear Jacob,
thank you for the patch.
> + struct gsm_bts *bts = (struct gsm_bts *) cmd->node;
> + if (!bts) {
I added an empty line between the two
> + if (! override)
> + return 0;
I removed the extrap space and added a talloc_free(tmp);
> +
> + r = self.do_set('bts.0.timezone', '-2,15,2')
> + self.assertEquals(r['mtype'], 'SET_REPLY')
> + self.assertEquals(r['var'], 'bts.0.timezone')
> + self.assertEquals(r['value'], '-2,15,2')
I added two commands with invalid input.. one with longer
input (where the extra data is just ignored) and one with
a shorter one.
applying it now and push it to master (then backport)