[PATCH] Add vty command for setting Access control classes

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Alexander Chemeris alexander.chemeris at gmail.com
Fri Jul 12 19:06:02 UTC 2013


On Fri, Jul 12, 2013 at 10:28 PM, Peter Stuge <peter at stuge.se> wrote:
>
> Ivan Kluchnikov wrote:
> > +DEFUN(cfg_bts_rach_ac_classes, cfg_bts_rach_ac_classes_cmd,
> > +      "rach access control classes (0|1) (0|1) (0|1) (0|1) (0|1) (0|1) (0|1) (0|1) (0|1) (0|1) x (0|1) (0|1) (0|1) (0|1) (0|1)",
> > +      RACH_STR
> > +      "Access control classes\n"
> > +      "Access control classes\n"
> > +      "Access control classes\n"
> > +      "Access is NOT barred for ACC 0\n"
> > +      "Access is barred for ACC 0\n"
> > +      "Access is NOT barred for ACC 1\n"
> ..
>
> The command looks pretty horrible. Do you think that there could be a
> better user interface than a single command with 16 parameters?
>
> I'd suggest something like: rach access control class (0..15) (0|1)

I like our way more, as it's a single line vs many-many lines. A
single line doesn't occupy so much screen space and is easier to
manipulate from VTY or over a slow satellite connection (happen
frequently here). Also it gives you the whole picture in a single
glance.

Does it sound like a valid reason?

--
Regards,
Alexander Chemeris.
CEO, Fairwaves LLC / ООО УмРадио
http://fairwaves.ru




More information about the OpenBSC mailing list