[PATCH] build: resolve link failure in libosmogsm when --disable-talloc is used

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Peter Stuge peter at stuge.se
Mon Feb 18 14:57:15 UTC 2013


Jan Engelhardt wrote:
> diff --git a/src/gsm/Makefile.am b/src/gsm/Makefile.am
> index b72a8d4..237e134 100644
> --- a/src/gsm/Makefile.am
> +++ b/src/gsm/Makefile.am
> @@ -23,5 +23,8 @@ libosmogsm_la_SOURCES = a5.c rxlev_stat.c tlv_parser.c comp128.c gsm_utils.c \
>  
>  libosmogsm_la_LDFLAGS = -Wl,--version-script=$(srcdir)/libosmogsm.map -version-info $(LIBVERSION)
>  libosmogsm_la_LIBADD = $(top_builddir)/src/libosmocore.la
> +if !ENABLE_TALLOC
> +libosmogsm_la_LIBDADD = -ltalloc
> +endif

It seems wrong to use libtalloc when --disable-talloc is used?

Why not fix the code to not use talloc_free() instead?

And another thing, was there only an error about talloc_free()?
That would mean an imbalance in the code which should be fixed..


//Peter




More information about the OpenBSC mailing list