LAPDm, msgb and osmo-bts breakage

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

jolly andreas at eversberg.eu
Fri Jan 13 06:07:10 UTC 2012


> Currently:
>         msgb_pull_l2h(msg);
>         msg->len = length;
>         msg->tail = msg->data + length;
hi holger,

you are right. the header (between l2h and l3h) is pulled away, but this
code assumes that there is nothing in front. you must use "msg->tail =
msg->l3h + lenght" to correctly set the length of the L3 data, in case
you have still something in front of l2h, so that l2h != data. since
osmocom does not have something in front of l2h, it works, even if it is
not the clean way.

regards,

andreas





More information about the OpenBSC mailing list