Adding patches to wireshark...

[Omar Atia]

Thanks It is clear for me !! just send me 1 pcap file to open it with the
patched wireshark and it should have abis-oml protocol sniffed inside it ,
in order to make sure that the patch is okay as I have added the c file
inside one place in Makefile.common I will copy the place below :

Under :
DISSECTOR_SRC= 
.
.
.
.
      packet-gsm_a_common.c           \
        packet-gsm_a_dtap.c             \
        packet-gsm_a_gm.c               \
        packet-gsm_abis_oml.c           \
        packet-gsm_a_rp.c               \
        packet-gsm_a_rr.c       \
        packet-gsm_bsslap.c             \


is this right ? shall I add it in different place ( C file and header are
created under ) /epan/dissectors

Thanks,
Omar Aia

-----Original Message-----
From: openbsc-bounces at lists.gnumonks.org
[mailto:openbsc-bounces at lists.gnumonks.org] On Behalf Of Holger Hans Peter
Freyther
Sent: Tuesday, January 11, 2011 5:41 PM
To: openbsc at lists.gnumonks.org
Subject: Re: Adding patches to wireshark...

On 01/11/2011 10:01 AM, Omar Atia wrote:
> Yes dear I worked git which I used to download the src for libosmocore and
> opensbsc...

:)


> Patch -p1 (patch file) it raises a problem in Makefile.common , and didn't
> patch the Makefile.common but it did create the C and header files for the
> below patch abis_oml.patch under dissector, but the issue in the make file
,
> how can I add them to make file in order to be compiled ...

Always hard to judge where the difficulty is. The GNU patch program is
leaving
a FILENAME.orig and a FILENAME.rej next to the file that failed
to be patched. In your case you should have a Makefile.common.rej that
shows you which 'hunk' (part of the patch) was not applied. You simply need
to
add the abis-oml c file to that...


> 
> Any way I will google git svn tonight and check it , but if you have any
> hint for the version of wireshark I should download the sources for it
let
> me know .

I have rebased the patches, added a README with the svn version that these
patches apply to to the OpenBSC git.


everything clear now?