Multiple BTS's on one one E1?

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Harald Welte laforge at gnumonks.org
Thu Aug 25 07:51:49 UTC 2011


On Wed, Aug 24, 2011 at 01:41:15PM +0200, Holger Hans Peter Freyther wrote:
> On 08/24/2011 09:49 AM, Harald Welte wrote:
> > +			if (bfd->fd) {
> > +				close(bfd->fd);
> > +				bfd->fd = 0;
> > +			}
> 
> maybe using -1 for 'invalid' fd's is better?

"-1" already has a different meaning in the same part of the code, it
means that there was some error in return to "open"

But yes, we could do "-2" or store the open result in a variable rather
than a structure member.  Feel free to do a follow-up patch ;)

Regards,
	Harald
-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)




More information about the OpenBSC mailing list