[PATCH 2/7] src: more robust ipaccess_idtag_parse()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Hans Peter Freyther holger at freyther.de
Wed Apr 13 11:38:41 UTC 2011


On 04/12/2011 07:55 PM, Pablo Neira Ayuso wrote:

>> Thanks, IIRC there is another issue here. We assume that the strings on the
>> wire contain a '\0', e.g. in the printf statements we rely on this. So we
>> could either put this in there or do something else.
> 
> Can I assume that all IPAC_IDTAG_* are all strings?

I'm sorry. I do not know.

> If so, I'll send a patch to check for the trailing \0 to:
> 
> dec->lv[t_tag].val = cur;
> 
> Sorry, I didn't get you in the first hand, I'm not ignoring your
> requests :-).
> 
> Let me know if this is not what you mean.

It would be good to find out which of these tags have the null termination and
which not.

holger





More information about the OpenBSC mailing list