[PATCH 2/7] src: more robust ipaccess_idtag_parse()

[Pablo Neira Ayuso]

Hi Holger,

On 11/04/11 17:52, Holger Hans Peter Freyther wrote:
> On 04/11/2011 05:04 PM, pablo at gnumonks.org wrote:
>> From: Pablo Neira Ayuso <pablo at gnumonks.org>
>>
> 
> Thanks, IIRC there is another issue here. We assume that the strings on the
> wire contain a '\0', e.g. in the printf statements we rely on this. So we
> could either put this in there or do something else.

Can I assume that all IPAC_IDTAG_* are all strings?

I mean all of these:

        [IPAC_IDTAG_SERNR]      = "Serial_Number",
        [IPAC_IDTAG_UNITNAME]   = "Unit_Name",
        [IPAC_IDTAG_LOCATION1]  = "Location_1",
        [IPAC_IDTAG_LOCATION2]  = "Location_2",
        [IPAC_IDTAG_EQUIPVERS]  = "Equipment_Version",
        [IPAC_IDTAG_SWVERSION]  = "Software_Version",
        [IPAC_IDTAG_IPADDR]     = "IP_Address",
        [IPAC_IDTAG_MACADDR]    = "MAC_Address",
        [IPAC_IDTAG_UNIT]       = "Unit_ID",

If so, I'll send a patch to check for the trailing \0 to:

dec->lv[t_tag].val = cur;

Sorry, I didn't get you in the first hand, I'm not ignoring your
requests :-).

Let me know if this is not what you mean.