Change in osmo-bsc[master]: om2000: Fix memory leak in OM2000 message handling

[laforge]

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26711 )


Change subject: om2000: Fix memory leak in OM2000 message handling
......................................................................

om2000: Fix memory leak in OM2000 message handling

Change-Id: I7a94320f3b3af65003df67c11fe7221dfc7d7d62
---
M src/osmo-bsc/abis_om2000.c
1 file changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/11/26711/1

diff --git a/src/osmo-bsc/abis_om2000.c b/src/osmo-bsc/abis_om2000.c
index 8ee6371..16320fc 100644
--- a/src/osmo-bsc/abis_om2000.c
+++ b/src/osmo-bsc/abis_om2000.c
@@ -3042,17 +3042,18 @@
 	if (!mo) {
 		LOGP(DNM, LOGL_ERROR, "Couldn't resolve MO for OM2K msg "
 		     "%s: %s\n", get_value_string(om2k_msgcode_vals, msg_type), msgb_hexdump(msg));
-		return 0;
+		goto no_mo;
 	}
 	if (!mo->fsm) {
 		LOGP(DNM, LOGL_ERROR, "MO object should not generate any message. fsm == NULL "
 		     "%s: %s\n", get_value_string(om2k_msgcode_vals, msg_type), msgb_hexdump(msg));
-		return 0;
+		goto no_mo;
 	}
 
 	/* Dispatch message to that MO */
 	om2k_mo_fsm_recvmsg(bts, mo, &odm);
 
+no_mo:
 	msgb_free(msg);
 	return rc;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26711
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7a94320f3b3af65003df67c11fe7221dfc7d7d62
Gerrit-Change-Number: 26711
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20220102/f23c6fdc/attachment.htm>