<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/26711">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">om2000: Fix memory leak in OM2000 message handling<br><br>Change-Id: I7a94320f3b3af65003df67c11fe7221dfc7d7d62<br>---<br>M src/osmo-bsc/abis_om2000.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/11/26711/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/abis_om2000.c b/src/osmo-bsc/abis_om2000.c</span><br><span>index 8ee6371..16320fc 100644</span><br><span>--- a/src/osmo-bsc/abis_om2000.c</span><br><span>+++ b/src/osmo-bsc/abis_om2000.c</span><br><span>@@ -3042,17 +3042,18 @@</span><br><span>     if (!mo) {</span><br><span>           LOGP(DNM, LOGL_ERROR, "Couldn't resolve MO for OM2K msg "</span><br><span>                   "%s: %s\n", get_value_string(om2k_msgcode_vals, msg_type), msgb_hexdump(msg));</span><br><span style="color: hsl(0, 100%, 40%);">-           return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+             goto no_mo;</span><br><span>  }</span><br><span>    if (!mo->fsm) {</span><br><span>           LOGP(DNM, LOGL_ERROR, "MO object should not generate any message. fsm == NULL "</span><br><span>                 "%s: %s\n", get_value_string(om2k_msgcode_vals, msg_type), msgb_hexdump(msg));</span><br><span style="color: hsl(0, 100%, 40%);">-           return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+             goto no_mo;</span><br><span>  }</span><br><span> </span><br><span>        /* Dispatch message to that MO */</span><br><span>    om2k_mo_fsm_recvmsg(bts, mo, &odm);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+no_mo:</span><br><span>  msgb_free(msg);</span><br><span>      return rc;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/26711">change 26711</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/26711"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7a94320f3b3af65003df67c11fe7221dfc7d7d62 </div>
<div style="display:none"> Gerrit-Change-Number: 26711 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>