Change in osmo-bts[master]: bts-trx: Fix rxgain & maxdly VTY values being reset

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Sep 28 10:25:05 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25610 )

Change subject: bts-trx: Fix rxgain & maxdly VTY values being reset
......................................................................

bts-trx: Fix rxgain & maxdly VTY values being reset

Recent commit added code to reset trx_provision_fsm state fields in orer
to support re-using the FSM once BTS is reconnected to a BSC.

However, some values being reset there are not set up when reconnecting
to the BSC, but rather configured through VTY at startup. Hence those
values should be kept.

Fixes: 32b51eca7d2a5215814db7843b1a0f8c74ea7527
Change-Id: I5c31241327b98386c313cd9377cf76c009456105
---
M src/osmo-bts-trx/trx_provision_fsm.c
1 file changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved



diff --git a/src/osmo-bts-trx/trx_provision_fsm.c b/src/osmo-bts-trx/trx_provision_fsm.c
index 7f42b47..36be76f 100644
--- a/src/osmo-bts-trx/trx_provision_fsm.c
+++ b/src/osmo-bts-trx/trx_provision_fsm.c
@@ -122,17 +122,13 @@
 	l1h->config.bsic_sent = false;
 	l1h->config.bsic_acked = false;
 
-	l1h->config.rxgain_valid = false;
-	l1h->config.rxgain = 0;
 	l1h->config.rxgain_sent = false;
 
 	l1h->config.nomtxpower_sent = false;
 	l1h->config.nomtxpower_acked = false;
 
-	l1h->config.maxdly_valid = false;
 	l1h->config.maxdly_sent = false;
 
-	l1h->config.maxdlynb_valid = false;
 	l1h->config.maxdlynb_sent = false;
 
 	for (tn = 0; tn < TRX_NR_TS; tn++) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25610
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5c31241327b98386c313cd9377cf76c009456105
Gerrit-Change-Number: 25610
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210928/3974d477/attachment.htm>


More information about the gerrit-log mailing list