<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25610">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bts-trx: Fix rxgain & maxdly VTY values being reset<br><br>Recent commit added code to reset trx_provision_fsm state fields in orer<br>to support re-using the FSM once BTS is reconnected to a BSC.<br><br>However, some values being reset there are not set up when reconnecting<br>to the BSC, but rather configured through VTY at startup. Hence those<br>values should be kept.<br><br>Fixes: 32b51eca7d2a5215814db7843b1a0f8c74ea7527<br>Change-Id: I5c31241327b98386c313cd9377cf76c009456105<br>---<br>M src/osmo-bts-trx/trx_provision_fsm.c<br>1 file changed, 0 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/trx_provision_fsm.c b/src/osmo-bts-trx/trx_provision_fsm.c</span><br><span>index 7f42b47..36be76f 100644</span><br><span>--- a/src/osmo-bts-trx/trx_provision_fsm.c</span><br><span>+++ b/src/osmo-bts-trx/trx_provision_fsm.c</span><br><span>@@ -122,17 +122,13 @@</span><br><span>    l1h->config.bsic_sent = false;</span><br><span>    l1h->config.bsic_acked = false;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  l1h->config.rxgain_valid = false;</span><br><span style="color: hsl(0, 100%, 40%);">-    l1h->config.rxgain = 0;</span><br><span>   l1h->config.rxgain_sent = false;</span><br><span> </span><br><span>      l1h->config.nomtxpower_sent = false;</span><br><span>      l1h->config.nomtxpower_acked = false;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    l1h->config.maxdly_valid = false;</span><br><span>         l1h->config.maxdly_sent = false;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- l1h->config.maxdlynb_valid = false;</span><br><span>       l1h->config.maxdlynb_sent = false;</span><br><span> </span><br><span>    for (tn = 0; tn < TRX_NR_TS; tn++) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25610">change 25610</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25610"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5c31241327b98386c313cd9377cf76c009456105 </div>
<div style="display:none"> Gerrit-Change-Number: 25610 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>