Change in simtrace2[master]: contrib/jenkins.sh: lower trace to make bl fit

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Tue Sep 28 09:42:20 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/25606 )

Change subject: contrib/jenkins.sh: lower trace to make bl fit
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/simtrace2/+/25606/2/contrib/jenkins.sh 
File contrib/jenkins.sh:

https://gerrit.osmocom.org/c/simtrace2/+/25606/2/contrib/jenkins.sh@48 
PS2, Line 48: 	fi
I suggest to remove the if... else here, and just always run

  make BOARD="$board" APP="$app"

then it picks up the default TRACE_LEVEL from firmware/Makefile. Otherwise its not so obvious where the level should be adjusted in the future (e.g. if another app gets too big).

To make it more explicit, maybe leave a comment here, that TRACE_LEVEL is adjusted in firmware/Makefile.



-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/25606
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I7d2947c84097035bed00ad489a175d614b4c388e
Gerrit-Change-Number: 25606
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Sep 2021 09:42:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210928/bbd21d9d/attachment.htm>


More information about the gerrit-log mailing list