<p><a href="https://gerrit.osmocom.org/c/simtrace2/+/25606">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/25606/2/contrib/jenkins.sh">File contrib/jenkins.sh:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/simtrace2/+/25606/2/contrib/jenkins.sh@48">Patch Set #2, Line 48:</a> <code style="font-family:monospace,monospace">     fi</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I suggest to remove the if... else here, and just always run</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  make BOARD="$board" APP="$app"</pre><p style="white-space: pre-wrap; word-wrap: break-word;">then it picks up the default TRACE_LEVEL from firmware/Makefile. Otherwise its not so obvious where the level should be adjusted in the future (e.g. if another app gets too big).</p><p style="white-space: pre-wrap; word-wrap: break-word;">To make it more explicit, maybe leave a comment here, that TRACE_LEVEL is adjusted in firmware/Makefile.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/25606">change 25606</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/25606"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7d2947c84097035bed00ad489a175d614b4c388e </div>
<div style="display:none"> Gerrit-Change-Number: 25606 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 28 Sep 2021 09:42:20 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>