This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25611 )
Change subject: MS Power Control Loop: Allow Turn off/on C/I independent from value setting
......................................................................
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/c/osmo-bsc/+/25611/1/src/osmo-bsc/bts_vty.c
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/25611/1/src/osmo-bsc/bts_vty.c@3904
PS1, Line 3904: if (strcmp(param, "ci") == 0) {
> Would it make sense to return early if !mp->enabled?
I prefer printing it so it becomes clear which ones are enabled or not by using show running-config.
https://gerrit.osmocom.org/c/osmo-bsc/+/25611/1/src/osmo-bsc/gsm_data.c
File src/osmo-bsc/gsm_data.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/25611/1/src/osmo-bsc/gsm_data.c@1203
PS1, Line 1203: .enabled = true,
> BTW, there was a discussion recently about disabling C/I based logic by default, given that osmo-trx […]
That's in any case another patch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25611
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id1224c2d9a52db2ed805c49e048d3086ed0167f5
Gerrit-Change-Number: 25611
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Sep 2021 18:17:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210927/1528fd0f/attachment.htm>