Change in osmo-bsc[master]: MS Power Control Loop: Allow Turn off/on C/I independent from value s...

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25611 )

Change subject: MS Power Control Loop: Allow Turn off/on C/I independent from value setting
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/25611/1/src/osmo-bsc/bts_vty.c 
File src/osmo-bsc/bts_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25611/1/src/osmo-bsc/bts_vty.c@3904 
PS1, Line 3904: 	if (strcmp(param, "ci") == 0) {
Would it make sense to return early if !mp->enabled?


https://gerrit.osmocom.org/c/osmo-bsc/+/25611/1/src/osmo-bsc/bts_vty.c@3978 
PS1, Line 3978: is_osmobts
Looks like an unrelated change to me.


https://gerrit.osmocom.org/c/osmo-bsc/+/25611/1/src/osmo-bsc/gsm_data.c 
File src/osmo-bsc/gsm_data.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25611/1/src/osmo-bsc/gsm_data.c@1203 
PS1, Line 1203: 		.enabled = true,
BTW, there was a discussion recently about disabling C/I based logic by default, given that osmo-trx currently reports relatively low C/I values, which do not work well with the default thresholds.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25611
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id1224c2d9a52db2ed805c49e048d3086ed0167f5
Gerrit-Change-Number: 25611
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Sep 2021 15:23:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210927/0eeb6018/attachment.htm>