Change in osmo-pcu[master]: pcuif: Submit data_req with len=0 as idle frames

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25535 )

Change subject: pcuif: Submit data_req with len=0 as idle frames
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/25535/1/src/gprs_rlcmac_sched.cpp 
File src/gprs_rlcmac_sched.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/25535/1/src/gprs_rlcmac_sched.cpp@520 
PS1, Line 520: 	if (tx_is_egprs && pdch->has_gprs_only_tbf_attached()) {
> Is it safe to skip this block?
It is safe in practice I'd say. Ideally indeed one would set fn_without_cs14 to 0 as soon as there's no TBF to transmit, since anyway that means there's no GPRS TBF which needs receiving synchronization. With this patch, we leave the value set to last value since we don't pass over here. However that's not a big issue, since for this counter to be incremented there's need for 2 TBFs to be active: 1 EGPRS and 1 GPRS.
Hence, at some point before that scenario we'll go through here with 1 EGPRS TBF *OR* 1 GPRS TBF, which will end in "tx_is_egprs && pdch->has_gprs_only_tbf_attached()" being false, hence the counter is properly initialized beofre really being of need.

I agree though that it's more clear to set it always, so I'll move it after the "tx_pdtch" goto tag.


https://gerrit.osmocom.org/c/osmo-pcu/+/25535/1/src/gprs_rlcmac_sched.cpp@535 
PS1, Line 535: gprs_bssgp_update_frames_sent
> Is it safe to skip this call?
I would say it's not really an issue since there's no TBFs anyway. In any case the leak rate counting is quite broken afaict. I'll move it after the tag too anyway.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25535
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ife718eeed2af011479c03099ea109518f04567bc
Gerrit-Change-Number: 25535
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Sep 2021 08:58:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210927/93c8a952/attachment.htm>