Change in osmo-pcu[master]: pcuif: Submit data_req with len=0 as idle frames

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25535 )

Change subject: pcuif: Submit data_req with len=0 as idle frames
......................................................................


Patch Set 1:

(2 comments)

Just to be sure...

https://gerrit.osmocom.org/c/osmo-pcu/+/25535/1/src/gprs_rlcmac_sched.cpp 
File src/gprs_rlcmac_sched.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/25535/1/src/gprs_rlcmac_sched.cpp@520 
PS1, Line 520: 	if (tx_is_egprs && pdch->has_gprs_only_tbf_attached()) {
Is it safe to skip this block?


https://gerrit.osmocom.org/c/osmo-pcu/+/25535/1/src/gprs_rlcmac_sched.cpp@535 
PS1, Line 535: gprs_bssgp_update_frames_sent
Is it safe to skip this call?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25535
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ife718eeed2af011479c03099ea109518f04567bc
Gerrit-Change-Number: 25535
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Sun, 26 Sep 2021 08:04:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210926/11dc5475/attachment.htm>