Change in osmo-bts[master]: osmo-bts-trx: bts_model_l1sap_down(): remove chan_nr patching

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at

fixeria gerrit-no-reply at
Sat Sep 25 06:57:07 UTC 2021

fixeria has uploaded this change for review. ( )

Change subject: osmo-bts-trx: bts_model_l1sap_down(): remove chan_nr patching

osmo-bts-trx: bts_model_l1sap_down(): remove chan_nr patching

Thanks to [1], there is no need to patch chan_nr for PDCH anymore.
The upper layers are now expected to use the correct values.

[1] I01680140c7201bf5284b278bceaea8ae01c122b2

Change-Id: I26eb2081eddb4ce900a7867897bc69c3f77dbd73
Related: OS#5238
M src/osmo-bts-trx/l1_if.c
1 file changed, 0 insertions(+), 13 deletions(-)

  git pull ssh:// refs/changes/81/25581/1

diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c
index f35c9ba..f3d8743 100644
--- a/src/osmo-bts-trx/l1_if.c
+++ b/src/osmo-bts-trx/l1_if.c
@@ -423,19 +423,6 @@
 				/* attempt to allocate an Error Concealment Unit instance, if available */
 				lchan->ecu_state = osmo_ecu_init(trx, lchan2ecu_codec(lchan));
-				/* trx_chan_desc[] in scheduler.c uses the RSL_CHAN_OSMO_PDCH cbits
-				 * (0xc0) to indicate the need for PDTCH and PTCCH SAPI activation.
-				 * However, 0xc0 is a cbits pattern exclusively used for Osmocom style
-				 * dyn TS (a non-standard RSL Chan Activ mod); hence, for IPA style dyn
-				 * TS, the chan_nr will never reflect 0xc0 and we would omit the
-				 * PDTCH,PTTCH SAPIs. To properly de-/activate the PDTCH SAPIs in
-				 * scheduler.c, make sure the 0xc0 cbits are set for de-/activating PDTCH
-				 * lchans, i.e. both Osmocom and IPA style dyn TS. (For Osmocom style dyn
-				 * TS, the chan_nr typically already reflects 0xc0, while it doesn't for
-				 * IPA style.) */
-				if (lchan->type == GSM_LCHAN_PDTCH)
-					chan_nr = RSL_CHAN_OSMO_PDCH | (chan_nr & ~RSL_CHAN_NR_MASK);
 				/* activate dedicated channel */
 				trx_sched_set_lchan(lchan, chan_nr, LID_DEDIC, true);
 				/* activate associated channel */

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I26eb2081eddb4ce900a7867897bc69c3f77dbd73
Gerrit-Change-Number: 25581
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list