<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25581">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo-bts-trx: bts_model_l1sap_down(): remove chan_nr patching<br><br>Thanks to [1], there is no need to patch chan_nr for PDCH anymore.<br>The upper layers are now expected to use the correct values.<br><br>[1] I01680140c7201bf5284b278bceaea8ae01c122b2<br><br>Change-Id: I26eb2081eddb4ce900a7867897bc69c3f77dbd73<br>Related: OS#5238<br>---<br>M src/osmo-bts-trx/l1_if.c<br>1 file changed, 0 insertions(+), 13 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/81/25581/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c</span><br><span>index f35c9ba..f3d8743 100644</span><br><span>--- a/src/osmo-bts-trx/l1_if.c</span><br><span>+++ b/src/osmo-bts-trx/l1_if.c</span><br><span>@@ -423,19 +423,6 @@</span><br><span>                               /* attempt to allocate an Error Concealment Unit instance, if available */</span><br><span>                           lchan->ecu_state = osmo_ecu_init(trx, lchan2ecu_codec(lchan));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-                           /* trx_chan_desc[] in scheduler.c uses the RSL_CHAN_OSMO_PDCH cbits</span><br><span style="color: hsl(0, 100%, 40%);">-                              * (0xc0) to indicate the need for PDTCH and PTCCH SAPI activation.</span><br><span style="color: hsl(0, 100%, 40%);">-                              * However, 0xc0 is a cbits pattern exclusively used for Osmocom style</span><br><span style="color: hsl(0, 100%, 40%);">-                           * dyn TS (a non-standard RSL Chan Activ mod); hence, for IPA style dyn</span><br><span style="color: hsl(0, 100%, 40%);">-                          * TS, the chan_nr will never reflect 0xc0 and we would omit the</span><br><span style="color: hsl(0, 100%, 40%);">-                                 * PDTCH,PTTCH SAPIs. To properly de-/activate the PDTCH SAPIs in</span><br><span style="color: hsl(0, 100%, 40%);">-                                * scheduler.c, make sure the 0xc0 cbits are set for de-/activating PDTCH</span><br><span style="color: hsl(0, 100%, 40%);">-                                * lchans, i.e. both Osmocom and IPA style dyn TS. (For Osmocom style dyn</span><br><span style="color: hsl(0, 100%, 40%);">-                                * TS, the chan_nr typically already reflects 0xc0, while it doesn't for</span><br><span style="color: hsl(0, 100%, 40%);">-                             * IPA style.) */</span><br><span style="color: hsl(0, 100%, 40%);">-                               if (lchan->type == GSM_LCHAN_PDTCH)</span><br><span style="color: hsl(0, 100%, 40%);">-                                  chan_nr = RSL_CHAN_OSMO_PDCH | (chan_nr & ~RSL_CHAN_NR_MASK);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>                            /* activate dedicated channel */</span><br><span>                             trx_sched_set_lchan(lchan, chan_nr, LID_DEDIC, true);</span><br><span>                                /* activate associated channel */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25581">change 25581</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25581"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I26eb2081eddb4ce900a7867897bc69c3f77dbd73 </div>
<div style="display:none"> Gerrit-Change-Number: 25581 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>