Change in osmo-bts[master]: osmo-bts-omldummy: Fix crash accessing null phy

[pespin]

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25565 )

Change subject: osmo-bts-omldummy: Fix crash accessing null phy
......................................................................

osmo-bts-omldummy: Fix crash accessing null phy

osmo-bts-omldummy is known to be specially in the sense that it has no
phy. This should ideally be changed to have some dummy object, but so
far that's how it is. A recent commit checking the phy's forgot about
the fact that BTS model has no phy. Let's fix it.

Fixes: 4ddc37ce7140e5ce6ca6cce5aeeefedc0d395d22
Change-Id: Iba7873530aac74b3bf799819890641196dacf170
---
M src/common/nm_bts_fsm.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/common/nm_bts_fsm.c b/src/common/nm_bts_fsm.c
index bad533f..0ad7655 100644
--- a/src/common/nm_bts_fsm.c
+++ b/src/common/nm_bts_fsm.c
@@ -72,6 +72,8 @@
 		oml_mo_tx_sw_act_rep(&bts->mo);
 
 		llist_for_each_entry(trx, &bts->trx_list, list) {
+			if (trx->bts->variant == BTS_OSMO_OMLDUMMY) /* In OMLDUMMY, phy=NULL */
+				continue;
 			/* During startup, phy_links are already opened, but if we are
 			 * re-connecting, phy_link was closed when disconnected from
 			 * previous BSC, so let's re-open it.

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25565
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iba7873530aac74b3bf799819890641196dacf170
Gerrit-Change-Number: 25565
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210923/e0e7a866/attachment.htm>