<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25565">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo-bts-omldummy: Fix crash accessing null phy<br><br>osmo-bts-omldummy is known to be specially in the sense that it has no<br>phy. This should ideally be changed to have some dummy object, but so<br>far that's how it is. A recent commit checking the phy's forgot about<br>the fact that BTS model has no phy. Let's fix it.<br><br>Fixes: 4ddc37ce7140e5ce6ca6cce5aeeefedc0d395d22<br>Change-Id: Iba7873530aac74b3bf799819890641196dacf170<br>---<br>M src/common/nm_bts_fsm.c<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/nm_bts_fsm.c b/src/common/nm_bts_fsm.c</span><br><span>index bad533f..0ad7655 100644</span><br><span>--- a/src/common/nm_bts_fsm.c</span><br><span>+++ b/src/common/nm_bts_fsm.c</span><br><span>@@ -72,6 +72,8 @@</span><br><span>               oml_mo_tx_sw_act_rep(&bts->mo);</span><br><span> </span><br><span>           llist_for_each_entry(trx, &bts->trx_list, list) {</span><br><span style="color: hsl(120, 100%, 40%);">+                      if (trx->bts->variant == BTS_OSMO_OMLDUMMY) /* In OMLDUMMY, phy=NULL */</span><br><span style="color: hsl(120, 100%, 40%);">+                         continue;</span><br><span>                    /* During startup, phy_links are already opened, but if we are</span><br><span>                        * re-connecting, phy_link was closed when disconnected from</span><br><span>                          * previous BSC, so let's re-open it.</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25565">change 25565</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25565"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iba7873530aac74b3bf799819890641196dacf170 </div>
<div style="display:none"> Gerrit-Change-Number: 25565 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>