This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgHello Jenkins Builder, laforge, pespin, fixeria, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/25582 to review the following change. Change subject: Revert "nm_bts_fsm: Make sure PHYs are opened when SW_ACTivating it" ...................................................................... Revert "nm_bts_fsm: Make sure PHYs are opened when SW_ACTivating it" This reverts commit 4ddc37ce7140e5ce6ca6cce5aeeefedc0d395d22. Reason for revert: segfault in osmo-bts-omldummy upon connecting to BSC See OS#5237 Change-Id: Ic8d19dc85407a2cf877d6c2aec1a90574311ad83 --- M src/common/nm_bts_fsm.c 1 file changed, 0 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/82/25582/1 diff --git a/src/common/nm_bts_fsm.c b/src/common/nm_bts_fsm.c index bad533f..54737bf 100644 --- a/src/common/nm_bts_fsm.c +++ b/src/common/nm_bts_fsm.c @@ -65,23 +65,10 @@ static void st_op_disabled_notinstalled(struct osmo_fsm_inst *fi, uint32_t event, void *data) { struct gsm_bts *bts = (struct gsm_bts *)fi->priv; - struct gsm_bts_trx *trx; switch (event) { case NM_EV_SW_ACT: oml_mo_tx_sw_act_rep(&bts->mo); - - llist_for_each_entry(trx, &bts->trx_list, list) { - /* During startup, phy_links are already opened, but if we are - * re-connecting, phy_link was closed when disconnected from - * previous BSC, so let's re-open it. - */ - struct phy_instance *pinst = trx_phy_instance(trx); - struct phy_link *plink = pinst->phy_link; - if (phy_link_state_get(plink) == PHY_LINK_SHUTDOWN) - bts_model_phy_link_open(plink); - } - nm_bts_fsm_state_chg(fi, NM_BTS_ST_OP_DISABLED_OFFLINE); return; default: -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic8d19dc85407a2cf877d6c2aec1a90574311ad83 Gerrit-Change-Number: 25582 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210923/6fee9d1a/attachment.htm>