<p>neels would like Jenkins Builder, laforge, pespin and fixeria to <strong>review</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25582">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Revert "nm_bts_fsm: Make sure PHYs are opened when SW_ACTivating it"<br><br>This reverts commit 4ddc37ce7140e5ce6ca6cce5aeeefedc0d395d22.<br><br>Reason for revert: segfault in osmo-bts-omldummy upon connecting to BSC<br>See OS#5237<br><br>Change-Id: Ic8d19dc85407a2cf877d6c2aec1a90574311ad83<br>---<br>M src/common/nm_bts_fsm.c<br>1 file changed, 0 insertions(+), 13 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/82/25582/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/nm_bts_fsm.c b/src/common/nm_bts_fsm.c</span><br><span>index bad533f..54737bf 100644</span><br><span>--- a/src/common/nm_bts_fsm.c</span><br><span>+++ b/src/common/nm_bts_fsm.c</span><br><span>@@ -65,23 +65,10 @@</span><br><span> static void st_op_disabled_notinstalled(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span> {</span><br><span>    struct gsm_bts *bts = (struct gsm_bts *)fi->priv;</span><br><span style="color: hsl(0, 100%, 40%);">-    struct gsm_bts_trx *trx;</span><br><span> </span><br><span>         switch (event) {</span><br><span>     case NM_EV_SW_ACT:</span><br><span>           oml_mo_tx_sw_act_rep(&bts->mo);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-          llist_for_each_entry(trx, &bts->trx_list, list) {</span><br><span style="color: hsl(0, 100%, 40%);">-                        /* During startup, phy_links are already opened, but if we are</span><br><span style="color: hsl(0, 100%, 40%);">-                   * re-connecting, phy_link was closed when disconnected from</span><br><span style="color: hsl(0, 100%, 40%);">-                     * previous BSC, so let's re-open it.</span><br><span style="color: hsl(0, 100%, 40%);">-                        */</span><br><span style="color: hsl(0, 100%, 40%);">-                     struct phy_instance *pinst = trx_phy_instance(trx);</span><br><span style="color: hsl(0, 100%, 40%);">-                     struct phy_link *plink = pinst->phy_link;</span><br><span style="color: hsl(0, 100%, 40%);">-                    if (phy_link_state_get(plink) == PHY_LINK_SHUTDOWN)</span><br><span style="color: hsl(0, 100%, 40%);">-                             bts_model_phy_link_open(plink);</span><br><span style="color: hsl(0, 100%, 40%);">-         }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>            nm_bts_fsm_state_chg(fi, NM_BTS_ST_OP_DISABLED_OFFLINE);</span><br><span>             return;</span><br><span>      default:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25582">change 25582</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25582"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic8d19dc85407a2cf877d6c2aec1a90574311ad83 </div>
<div style="display:none"> Gerrit-Change-Number: 25582 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>