Change in pysim[master]: pySim-shell: refactor __main__ section

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25484 )

Change subject: pySim-shell: refactor __main__ section
......................................................................


Patch Set 6:

(4 comments)

https://gerrit.osmocom.org/c/pysim/+/25484/2/pySim-shell.py 
File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/25484/2/pySim-shell.py@66 
PS2, Line 66: 		print("No card detected!")
> A more Python'ish way would be to raise exceptions from this function, so you always get nice backtr […]
(still unresolved)


https://gerrit.osmocom.org/c/pysim/+/25484/2/pySim-shell.py@71 
PS2, Line 71: 		print("Could not detect card type!")
> Same here, rather throw an exception.
(still unresolved)


https://gerrit.osmocom.org/c/pysim/+/25484/6/pySim-shell.py 
File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/25484/6/pySim-shell.py@69 
PS6, Line 69: readble
readable


https://gerrit.osmocom.org/c/pysim/+/25484/6/pySim-shell.py@529 
PS6, Line 529: ==
is



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/25484
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Id2a0f2012b84ce61f5c0c14404df559fca4ddfcd
Gerrit-Change-Number: 25484
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 23 Sep 2021 12:47:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210923/9236d553/attachment.htm>