<p><a href="https://gerrit.osmocom.org/c/pysim/+/25484">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/pysim/+/25484/2/pySim-shell.py">File pySim-shell.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/25484/2/pySim-shell.py@66">Patch Set #2, Line 66:</a> <code style="font-family:monospace,monospace">            print("No card detected!")</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">A more Python'ish way would be to raise exceptions from this function, so you always get nice backtr […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">(still unresolved)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/25484/2/pySim-shell.py@71">Patch Set #2, Line 71:</a> <code style="font-family:monospace,monospace">            print("Could not detect card type!")</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Same here, rather throw an exception.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">(still unresolved)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/pysim/+/25484/6/pySim-shell.py">File pySim-shell.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/25484/6/pySim-shell.py@69">Patch Set #6, Line 69:</a> <code style="font-family:monospace,monospace">readble</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">readable</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/25484/6/pySim-shell.py@529">Patch Set #6, Line 529:</a> <code style="font-family:monospace,monospace">==</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">is</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/25484">change 25484</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/25484"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id2a0f2012b84ce61f5c0c14404df559fca4ddfcd </div>
<div style="display:none"> Gerrit-Change-Number: 25484 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 23 Sep 2021 12:47:09 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>