Change in libosmocore[master]: refactor stat_item: get rid of FIFO and "skipped" error

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at

neels gerrit-no-reply at
Tue Sep 21 10:36:19 UTC 2021

neels has posted comments on this change. ( )

Change subject: refactor stat_item: get rid of FIFO and "skipped" error

Patch Set 3:

> Patch Set 3:
> I think those fields are mostly aimed at internal use by stats reporter, and I don't think anyone should be using those directly out of libosmocore.

well, "think" and "should" is the problem: it is public API and this patch breaks it.

This is a case of deciding to break an axiomatic principle because we're pretty sure to get away with it.
It really seems ok to do it, but it's objectively wrong from the underlying libosmo* release principles.
I'd like to have Harald's opinion on that.

I'm kind of leaning towards making osmo_stats_item2 instead.
We could then also streamline the new API a bit.

If Harald thinks that that's obsessive compulsive perfectionism and not worth the time, then I'd be ok to drop those struct members instead.

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I137992a5479fc39bbceb6c6c2af9c227bd33b39b
Gerrit-Change-Number: 25464
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at>
Gerrit-Reviewer: laforge <laforge at>
Gerrit-CC: fixeria <vyanitskiy at>
Gerrit-CC: osmith <osmith at>
Gerrit-CC: pespin <pespin at>
Gerrit-Comment-Date: Tue, 21 Sep 2021 10:36:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list