<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 3:</p><p style="white-space: pre-wrap; word-wrap: break-word;">I think those fields are mostly aimed at internal use by stats reporter, and I don't think anyone should be using those directly out of libosmocore.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">well, "think" and "should" is the problem: it is public API and this patch breaks it.</p><p style="white-space: pre-wrap; word-wrap: break-word;">This is a case of deciding to break an axiomatic principle because we're pretty sure to get away with it.<br>It really seems ok to do it, but it's objectively wrong from the underlying libosmo* release principles.<br>I'd like to have Harald's opinion on that.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm kind of leaning towards making osmo_stats_item2 instead.<br>We could then also streamline the new API a bit.</p><p style="white-space: pre-wrap; word-wrap: break-word;">If Harald thinks that that's obsessive compulsive perfectionism and not worth the time, then I'd be ok to drop those struct members instead.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/25464">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/25464">change 25464</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/25464"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I137992a5479fc39bbceb6c6c2af9c227bd33b39b </div>
<div style="display:none"> Gerrit-Change-Number: 25464 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 21 Sep 2021 10:36:19 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>