This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25400 ) Change subject: Add stats: pcu.bts.N.pdch.occupied.gprs/egprs ...................................................................... Patch Set 3: (3 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/25400/3/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/25400/3/src/pdch.cpp@1073 PS3, Line 1073: num_tbfs_update(tbf, 1); it's a bool, then true/false. https://gerrit.osmocom.org/c/osmo-pcu/+/25400/3/src/pdch.cpp@1093 PS3, Line 1093: num_tbfs_update(tbf, 0); it's a bool, then true/false. https://gerrit.osmocom.org/c/osmo-pcu/+/25400/2/src/tbf.cpp File src/tbf.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/25400/2/src/tbf.cpp@779 PS2, Line 779: if (direction == GPRS_RLCMAC_DL_TBF && pdch[ts]->dl_tbf_by_tfi(m_tfi) != this) > If I remove the checks, it will run num_tbfs_update on PDCHs where _any_ TBF is attached, instead of […] IIRC pdch is an array of pointers to pdch structs, which are non null only on TS where the TBF is attached. Hence, if the TBF is not attached toa given PDCH, the first condition will skip the loop iteration. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0c0a1121b4ae5f031782e7e63a0c28eb0b6c8b42 Gerrit-Change-Number: 25400 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 17 Sep 2021 10:15:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith at sysmocom.de> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210917/812c3854/attachment.htm>