Change in osmo-ttcn3-hacks[master]: pcu: Support Neighbor Address Resolution over PCUIF

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Sep 14 09:11:06 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25406 )

Change subject: pcu: Support Neighbor Address Resolution over PCUIF
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25406/2/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25406/2/pcu/PCU_Tests.ttcn@6161 
PS2, Line 6161: 	if (mp_ctrl_neigh_ip != "") { /* PCU using old CTRL neigh addr resolution iface */
> What's the thought process here? So you've added code paths to deal with both the old and new way in […]
Because these two tests are really specific to the underlaying CTRL protocol. It makes no sense to run them or try to apply them for the new interface which is unix socket based, with structured messages.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25406
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I05f1aabc64fc5bc4740b0d8afd8990b485eacd50
Gerrit-Change-Number: 25406
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 14 Sep 2021 09:11:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210914/406eb07d/attachment.htm>


More information about the gerrit-log mailing list