Change in osmo-ttcn3-hacks[master]: pcu: Support Neighbor Address Resolution over PCUIF

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25406 )

Change subject: pcu: Support Neighbor Address Resolution over PCUIF
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25406/2/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25406/2/pcu/PCU_Tests.ttcn@4558 
PS2, Line 4558: 	var boolean use_old_ctrl_iface := mp_ctrl_neigh_ip != "";
> Because: […]
Ack


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25406/2/pcu/PCU_Tests.ttcn@6161 
PS2, Line 6161: 	if (mp_ctrl_neigh_ip != "") { /* PCU using old CTRL neigh addr resolution iface */
What's the thought process here? So you've added code paths to deal with both the old and new way in each function, and here you only enable the tests if the new neighbor address resolution is used? Why not always enable the tests?

I'm curious about that, everything else looks good to me.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25406
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I05f1aabc64fc5bc4740b0d8afd8990b485eacd50
Gerrit-Change-Number: 25406
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 14 Sep 2021 06:26:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210914/70145dec/attachment.htm>