Change in osmo-bsc[master]: lchan_fsm: Fix comment

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Sep 13 09:08:43 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25411 )

Change subject: lchan_fsm: Fix comment
......................................................................

lchan_fsm: Fix comment

A previous commit (Feb 05 2021) moved copy of TA value to some other
place to fix some related issues, but forgot to update the comment.

Fixes: b03e73f27b26449864296fdab84f6fb6e1978c45
Change-Id: Ia10038919b6650dff45b7233f58fea94e9808712
---
M src/osmo-bsc/lchan_fsm.c
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index 1b59b45..a18cba5 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -691,7 +691,7 @@
 	lchan->conn = info->for_conn;
 
 	/* If there is a previous lchan, and the new lchan is on the same cell as previous one,
-	 * take over power and TA values. Otherwise, use max power and zero TA. */
+	 * take over power values. Otherwise, use max power. */
 	if (old_lchan && old_lchan->ts->trx->bts == bts) {
 		ms_power_dbm = ms_pwr_dbm(bts->band, old_lchan->ms_power);
 		lchan_update_ms_power_ctrl_level(lchan, ms_power_dbm >= 0 ? ms_power_dbm : bts->ms_max_power);
@@ -699,8 +699,7 @@
 	} else {
 		lchan_update_ms_power_ctrl_level(lchan, bts->ms_max_power);
 		/* Upon last entering the UNUSED state, from lchan_reset():
-		 * - bs_power_db is still zero, 0dB reduction, output power = Pn.
-		 * - TA is still zero, to be determined by RACH. */
+		 * - bs_power_db is still zero, 0dB reduction, output power = Pn. */
 
 		/* Default BS Power reduction value (in dB) */
 		if (bts->bs_power_ctrl.mode == GSM_PWR_CTRL_MODE_DYN_BTS)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25411
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia10038919b6650dff45b7233f58fea94e9808712
Gerrit-Change-Number: 25411
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210913/3cd99596/attachment.htm>


More information about the gerrit-log mailing list