<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25411">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lchan_fsm: Fix comment<br><br>A previous commit (Feb 05 2021) moved copy of TA value to some other<br>place to fix some related issues, but forgot to update the comment.<br><br>Fixes: b03e73f27b26449864296fdab84f6fb6e1978c45<br>Change-Id: Ia10038919b6650dff45b7233f58fea94e9808712<br>---<br>M src/osmo-bsc/lchan_fsm.c<br>1 file changed, 2 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c</span><br><span>index 1b59b45..a18cba5 100644</span><br><span>--- a/src/osmo-bsc/lchan_fsm.c</span><br><span>+++ b/src/osmo-bsc/lchan_fsm.c</span><br><span>@@ -691,7 +691,7 @@</span><br><span>   lchan->conn = info->for_conn;</span><br><span> </span><br><span>      /* If there is a previous lchan, and the new lchan is on the same cell as previous one,</span><br><span style="color: hsl(0, 100%, 40%);">-  * take over power and TA values. Otherwise, use max power and zero TA. */</span><br><span style="color: hsl(120, 100%, 40%);">+     * take over power values. Otherwise, use max power. */</span><br><span>      if (old_lchan && old_lchan->ts->trx->bts == bts) {</span><br><span>          ms_power_dbm = ms_pwr_dbm(bts->band, old_lchan->ms_power);</span><br><span>             lchan_update_ms_power_ctrl_level(lchan, ms_power_dbm >= 0 ? ms_power_dbm : bts->ms_max_power);</span><br><span>@@ -699,8 +699,7 @@</span><br><span>   } else {</span><br><span>             lchan_update_ms_power_ctrl_level(lchan, bts->ms_max_power);</span><br><span>               /* Upon last entering the UNUSED state, from lchan_reset():</span><br><span style="color: hsl(0, 100%, 40%);">-              * - bs_power_db is still zero, 0dB reduction, output power = Pn.</span><br><span style="color: hsl(0, 100%, 40%);">-                * - TA is still zero, to be determined by RACH. */</span><br><span style="color: hsl(120, 100%, 40%);">+            * - bs_power_db is still zero, 0dB reduction, output power = Pn. */</span><br><span> </span><br><span>             /* Default BS Power reduction value (in dB) */</span><br><span>               if (bts->bs_power_ctrl.mode == GSM_PWR_CTRL_MODE_DYN_BTS)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25411">change 25411</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/25411"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia10038919b6650dff45b7233f58fea94e9808712 </div>
<div style="display:none"> Gerrit-Change-Number: 25411 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>