Change in osmo-ttcn3-hacks[master]: ns: always clean up the ns_codec

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Sep 7 12:42:52 UTC 2021


lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25353 )

Change subject: ns: always clean up the ns_codec
......................................................................

ns: always clean up the ns_codec

The f_clean_ns_codec() was introduced later to clean up the ns_codec
properly.

Change-Id: I7a84f75ebd1c68b3c0a6b55b8c49903c51dd6b92
---
M ns/NS_Tests.ttcn
1 file changed, 19 insertions(+), 0 deletions(-)

Approvals:
  lynxis lazus: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn
index 105d397..8b321ff 100644
--- a/ns/NS_Tests.ttcn
+++ b/ns/NS_Tests.ttcn
@@ -131,6 +131,7 @@
 
 	setverdict(pass);
 	f_sleep(1.0);
+	f_clean_ns_codec();
 }
 
 testcase TC_tx_reset_tx_alive() runs on RAW_Test_CT {
@@ -145,6 +146,7 @@
 
 	setverdict(pass);
 	f_sleep(1.0);
+	f_clean_ns_codec();
 }
 
 testcase TC_tx_reset_rx_alive() runs on RAW_Test_CT {
@@ -160,6 +162,7 @@
 
 	setverdict(pass);
 	f_sleep(1.0);
+	f_clean_ns_codec();
 }
 
 /* 48.016 7.2.1 transmit a UNIT DATA over a BLOCKED NSVC when ttcn3 blocked it
@@ -227,6 +230,7 @@
 	f_outgoing_ns_unblock();
 	setverdict(pass);
 	f_sleep(1.0);
+	f_clean_ns_codec();
 }
 
 /* 48.016 7.2 tx unblock retries
@@ -254,6 +258,7 @@
 	f_outgoing_ns_unblock();
 	setverdict(pass);
 	f_sleep(1.0);
+	f_clean_ns_codec();
 }
 
 /* 48.016 7.2 block procedure
@@ -318,6 +323,7 @@
 testcase TC_tx_block_by_vty() runs on RAW_Test_CT {
 	tx_block_by_vty(30.0);
 	f_sleep(1.0);
+	f_clean_ns_codec();
 }
 
 /* 48.016 7.2 block precedure by vty and reset the NSVC.
@@ -336,6 +342,7 @@
 	[] T.timeout { setverdict(pass); }
 	}
 	deactivate(d);
+	f_clean_ns_codec();
 }
 
 /* 48.016 7.4.1 ignore unexpected NS_ALIVE ACK */
@@ -347,6 +354,7 @@
 	f_fails_except_reset();
 	setverdict(pass);
 	f_sleep(1.0);
+	f_clean_ns_codec();
 }
 
 /* 48.016 7.3.1 NS_RESET with wrong nsei */
@@ -359,6 +367,7 @@
 	f_fails_except_reset();
 	setverdict(pass);
 	f_sleep(1.0);
+	f_clean_ns_codec();
 }
 
 /* 48.016 7.3.1 NS_RESET with wrong nsvci */
@@ -371,6 +380,7 @@
 	f_fails_except_reset();
 	setverdict(pass);
 	f_sleep(1.0);
+	f_clean_ns_codec();
 }
 
 /* 48.016 7.3.1 NS_RESET with wrong nsvci + nsei */
@@ -383,6 +393,7 @@
 	f_fails_except_reset();
 	setverdict(pass);
 	f_sleep(1.0);
+	f_clean_ns_codec();
 }
 
 /* 48.016 7.3.1 NS_RESET_ACK with wrong nsei */
@@ -395,6 +406,7 @@
 	f_fails_except_reset();
 	setverdict(pass);
 	f_sleep(1.0);
+	f_clean_ns_codec();
 }
 
 /* 48.016 7.3.1 NS_RESET_ACK with wrong nsvci */
@@ -407,6 +419,7 @@
 	f_fails_except_reset();
 	setverdict(pass);
 	f_sleep(1.0);
+	f_clean_ns_codec();
 }
 
 /* 48.016 7.3.1 NS_RESET_ACK with wrong nsvci + nsei */
@@ -419,6 +432,7 @@
 	f_fails_except_reset();
 	setverdict(pass);
 	f_sleep(1.0);
+	f_clean_ns_codec();
 }
 
 /* 48.016 7.3.1 ignore unexpected NS_RESET_ACK after NS_RESET+ALIVE */
@@ -439,6 +453,7 @@
 	f_ensure_no_ns(answer_alive := true, tout := 15.0);
 	setverdict(pass);
 	f_sleep(1.0);
+	f_clean_ns_codec();
 }
 
 /* 48.016 7.3 NS_RESET retries */
@@ -460,6 +475,7 @@
 	}
 
 	f_sleep(1.0);
+	f_clean_ns_codec();
 }
 
 /* 48.016 behave RESET_ACK got dropped
@@ -493,6 +509,7 @@
 	}
 
 	f_sleep(1.0);
+	f_clean_ns_codec();
 }
 
 /* 48.016 7.4 test procedure for frame relay with a single nsvci */
@@ -526,10 +543,12 @@
 
 testcase TC_alive_retries_single_reset() runs on RAW_Test_CT {
 	f_alive_retries_single(reset := true);
+	f_clean_ns_codec();
 }
 
 testcase TC_alive_retries_single_no_resp() runs on RAW_Test_CT {
 	f_alive_retries_single(reset := false);
+	f_clean_ns_codec();
 }
 
 /* 48.016 SNS test cases */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25353
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7a84f75ebd1c68b3c0a6b55b8c49903c51dd6b92
Gerrit-Change-Number: 25353
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210907/bb8ddd78/attachment.htm>


More information about the gerrit-log mailing list